CSLA 2.1 - N level undo
Old forum URL: forums.lhotka.net/forums/t/1257.aspx
Ouistiti posted on Tuesday, September 19, 2006
Hi,
I've recently downloaded csla 2.1, and I've encountered a problem with the new Saved event.
I have a winform that has uses this event to update the reference to the new saved object. If BeginEdit is called after the event handler has been set, the CopyState method raises a SerializationException (<form> type is not marked as serializable) because it tries to serialize the _nonSerializableSavedHandlers field, which is not marked as NotUndoable. I've noticed that the _nonSerializableHandlers field of UndoableBase is also not marked as NotUndoable, but CopyState's loop stops when it reaches typeof(UndoableBase) in the inheritance chain, so it's value is not serialized.
Should _nonSerializableSavedHandlers be marked as NotUndoable, or am I missing something ?
Thanks for your answer.
RockfordLhotka replied on Tuesday, September 19, 2006
Thank you, that is most certainly a bug. I have fixed it in cvs (adding the NotUndoable attribute), so it will be fixed in the next release.
Ouistiti replied on Tuesday, September 19, 2006
Thank you for your quick answer.ajj3085 replied on Tuesday, September 19, 2006
Rocky..
Is the 2.1 RTM (RTWeb?) still slated for September?
Andy
RockfordLhotka replied on Tuesday, September 19, 2006
Yes.
The one major outstanding issue (that I'm aware of) is that
the CslaDataSource can't be added as a "new data source" directly from a
grid/details control. I am still hoping to find time to troubleshoot that issue
- but even if I don't get time I'll release with that as a known issue (because
the control works in other scenarios, so there is a
workaround).
However, I am also trying to give people as much time to
work with the beta as possible to find and squish any other bugs - like the one
on this thread...
Rocky
Is
the 2.1 RTM (RTWeb?) still slated for September?
Andy
Sarosh replied on Tuesday, September 19, 2006
Hi!
What does cvs mean how can we get this change or which class/property should we add the NotUndoable attribute to?
Rocky, is there a way that we can get notified whenever some sends us a reply to message in the forum(s)
Sarosh
RockfordLhotka replied on Tuesday, September 19, 2006
I keep all the source code in source control using cvs. The
cvs repository is publicly available (for read) to everyone, both through the
web and with a cvs client. You can go to www.lhotka.net/cslacvs to view the code
and its history, and you can go here
for instructions on using a cvs client.
Regarding the forum, there are a couple ways to be
notified. You can use the RSS feed, or you can enable email support in your
profile, or you can enable email support for just this
thread.
Rocky
Hi!
What does cvs mean how can we get this change or which class/property
should we add the NotUndoable attribute to?
Rocky, is there a way that we can get notified whenever some sends us a
reply to message in the forum(s)
Sarosh
Sarosh replied on Tuesday, September 19, 2006
Hi!
Got it!
Thanks
Sarosh
Copyright (c) Marimer LLC
