CslaDataSource Bug in 2.1.2.0

CslaDataSource Bug in 2.1.2.0

Old forum URL: forums.lhotka.net/forums/t/2235.aspx


LEEG posted on Monday, January 29, 2007

The SelectObjectArgs method in CslaDataSource appears to have a bug in it.  Line 316 is as follows:

      if (mSortExpression.Substring(mSortExpression.Length - 5) == " DESC")

This works fine as long as mSortExpression is at least 5 characters in length, but if it is something shorter it will cause an exception.

The following change seems to fix the problem in the C# version.

      if (mSortExpression.Length >= 5 && mSortExpression.Substring(mSortExpression.Length - 5) == " DESC")

Lee

 

RockfordLhotka replied on Monday, January 29, 2007

Good point... I'll fix that soon.

A colleague of mine (Chuck at Magenic is converting my cvs repositories over to svn format, and I hope to have my repository alive again tomorrow.

This cvs->svn conversion isn't as easy as you'd think, because I started using cvs with a very old version of cvsnt, which apparently didn't use exactly the same format as expected by the cvs2svn tools...

Copyright (c) Marimer LLC