I think line 468 of DecoratedRuleArgs.cs should be
sb
.AppendFormat( "{0}={1}", System.Uri.EscapeDataString(item.Key), System.Uri.EscapeDataString(item.Value.ToString()) );because sometimes the value can be a regular expression string containing ? and & signs.
Please correct me if I'm wrong.
Regards,
Rob
I think you are right, that sounds like a potential issue. I'll add it to the list of things to work on. Thanks!
Good point – thanks!
I’ve now changed the code to address these issues in
3.5.1.
Rocky
From: nelis
[mailto:cslanet@lhotka.net]
Sent: Thursday, June 26, 2008 7:36 AM
To: rocky@lhotka.net
Subject: Re: [CSLA .NET] DecoratedRuleArgs bug?
Something else to consider: null values ?
Just downloaded 3.5.1
DecoratedRuleArgs.ToString() still contains:
sb.AppendFormat(
"{0}={1}", item.Key, item.Value.ToString());without checking item.Value for a null value
I must have made that change after I did the beta release. It is
in svn
http://www.lhotka.net/cslacvs/viewvc.cgi/trunk/cslacs/Csla/Validation/DecoratedRuleArgs.cs
Rocky
From: nelis
[mailto:cslanet@lhotka.net]
Sent: Thursday, July 03, 2008 7:08 AM
To: rocky@lhotka.net
Subject: Re: [CSLA .NET] RE: DecoratedRuleArgs bug?
Just downloaded 3.5.1
DecoratedRuleArgs.ToString()
still contains:
sb.AppendFormat("{0}={1}", item.Key,
item.Value.ToString());
without checking item.Value
for a null value
Yes, I’ve created a 3.0.5 in subversion (the
branches\v3-0-x folder) that contains the fix, so when I do a 3.0.5 maintenance
release it’ll be in there.
Rocky
From: William
[mailto:cslanet@lhotka.net]
Sent: Thursday, July 03, 2008 6:54 PM
To: rocky@lhotka.net
Subject: Re: [CSLA .NET] RE: RE: DecoratedRuleArgs bug?
Does this apply to version 3.0.4 as well?
Copyright (c) Marimer LLC